can't find the rtmpdump release thread?

[Eldorado]

Sorry for resurrecting an old thread, but was the only one I could find where there was talk of including KSV's patches to the official RTMPDump site

The XBMC team wants to only include 'official' librtmp builds into their releases, so is incorporating the work KSV has done into the main source or posting the binaries/source on the rtmpdump site a possibility?

[KSV]

Well the short answer is no. there are many patches lying around on the mailing list without someone reviewing or committing them. also there is lack of positive attitude.

[karlo2105]

Originally Posted by Eldorado

The XBMC team wants to only include 'official' librtmp builds into their releases, so is incorporating the work KSV has done into the main source or posting the binaries/source on the rtmpdump site a possibility?

Why don't you include KSV patches, he has done so patches work so far, so his release is relevant to be used by XBMC team or you prefere to stay with official but unptached release.

[Eldorado]

Originally Posted by karlo2105

Why don't you include KSV patches, he has done so patches work so far, so his release is relevant to be used by XBMC team or you prefere to stay with official but unptached release.

Well its not my decision as I'm just a user and an addon dev, not apart of the XBMC dev team so it's ultimately up to them.. I'm just trying to get some wheels turning and have up to date librtmp builds included

Since KSV says it's a no then I think this is the next best option, I'll pitch them the idea and see if it gets somewhere

thanks!

[svnpenn]

With all due respect to KSV, he hasnt posted a single commit to RtmpDump, only a flood of combined patch files.

I find this very strange because he has done well with his "Scripts" repo.

[karlo2105]

Originally Posted by svnpenn

With all due respect to KSV, he hasnt posted a single commit to RtmpDump, only a flood of combined patch files.

I find this very strange because he has done well with his "Scripts" repo.

KSV is keeping rtmpdump up to date and for this he should be acknowledged. Without his patches many streams would not work and I don't think there is many persons like him who would do it regulary.
Xeeby managed to open handshake 10 and I am grateful for this to him.
KSV is maintining several scripts up to date. I guss he has also job and family life. So instead of complaining you could at least recognize that he is doing his best.

[svnpenn]

Originally Posted by karlo2105

So instead of complaining you could at least recognize that he is doing his best

Originally Posted by svnpenn

With all due respect to KSV, he hasnt posted a single commit to RtmpDump, only a flood of combined patch files.

I find this very strange because he has done well with his "Scripts" repo.

​​​​​

[KSV]

Originally Posted by svnpenn

he hasnt posted a single commit to RtmpDump, only a flood of combined patch files.

flood? oh really

i have never sent my combined patch file to mailing list. all the patches i submitted there were segregated and explained separately. IIRC last patch i sent was related to some RTMPT fixes but nobody cared to review it. combined patch file is only included with my package releases and makes it easier to apply it cleanly against latest git revision with single command instead of many separate patches generated against different git revisions.

how far you got when you submitted my live flag detection patch? they started bashing it saying it's invalid code and will crash while it's perfectly valid code and works as intended. it's not my job to convince someone to include it in their repo. honestly i don't care if it's in official repo or not. if i can use my written code that's good enough for me.

[svnpenn]

Originally Posted by KSV

i have never sent my combined patch file to mailing list. all the patches i submitted there were segregated and explained separately. IIRC last patch i sent was related to some RTMPT fixes but nobody cared to review it. combined patch file is only included with my package releases and makes it easier to apply it cleanly against latest git revision with single command instead of many separate patches generated against different git revisions.

how far you got when you submitted my live flag detection patch? they started bashing it saying it's invalid code and will crash while it's perfectly valid code and works as intended. it's not my job to convince someone to include it in their repo. honestly i don't care if it's in official repo or not. if i can use my written code that's good enough for me.

Pretty much all this is true.

My beef is with a single patch file users have no way to see the code changes involved in each patch. If a user wanted to implement just one of your changes, they would have to pick through your patch file and figure out what parts are relevant for each change, as I have.

[karlo2105]

Originally Posted by svnpenn

Pretty much all this is true.

My beef is with a single patch file users have no way to see the code changes involved in each patch. If a user wanted to implement just one of your changes, they would have to pick through your patch file and figure out what parts are relevant for each change, as I have.

Why would user implement only one patch from KSV and not all? It's nonsense.