Quote:
|
Originally Posted by KSV
i have never sent my combined patch file to mailing list. all the patches i submitted there were segregated and explained separately. IIRC last patch i sent was related to some RTMPT fixes but nobody cared to review it. combined patch file is only included with my package releases and makes it easier to apply it cleanly against latest git revision with single command instead of many separate patches generated against different git revisions.
how far you got when you submitted my live flag detection patch? they started bashing it saying it's invalid code and will crash while it's perfectly valid code and works as intended. it's not my job to convince someone to include it in their repo. honestly i don't care if it's in official repo or not. if i can use my written code that's good enough for me.
|
Pretty much all this is true.
My beef is with a single patch file users have no way to see the code changes involved in each patch. If a user wanted to implement just one of your changes, they would have to pick through your patch file and figure out what parts are relevant for each change, as I have.